Test update, ruff checks, deprecations warnings and import checks. #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
|
|
||
| loader = importlib.util.find_spec("triangle") |
There was a problem hiding this comment.
The imports are all checked in this file and in the test of the software the consts are imported from here.
| @@ -517,7 +500,7 @@ def validate(self): | |||
| # print("Downloading the Extension JSON schema file(s):") | |||
| if "extensions" in self.j: | |||
| for ext in self.j["extensions"]: | |||
| theurl = self.j["extensions"][ext]["url"] | |||
There was a problem hiding this comment.
I disabled this line because it was not used.
| @@ -1054,7 +1038,10 @@ def get_info(self, long=False): | |||
| if geom["semantics"] is not None: | |||
| for srf in geom["semantics"]["surfaces"]: | |||
| sem_srf.add(srf["type"]) | |||
| getsorted = lambda a: sorted(list(a)) | |||
There was a problem hiding this comment.
This change was required by ruff
| @@ -1430,27 +1415,7 @@ def merge(self, lsCMs): | |||
| raise KeyError( | |||
| f"The member 'values' is missing from the texture '{m}' in CityObject {theid}" | |||
| ) | |||
| # -- metadata | |||
| if self.has_metadata_extended() or cm.has_metadata_extended(): | |||
There was a problem hiding this comment.
this code had to be removed as there are no metadata_extended anymore
| @@ -2047,17 +2011,6 @@ def filter_lod(self, thelod): | |||
| self.remove_duplicate_vertices() | |||
| self.remove_orphan_vertices() | |||
| self.update_bbox() | |||
| # -- metadata | |||
| if self.has_metadata_extended(): | |||
There was a problem hiding this comment.
as above, this too had to be removed.
| nodes.append({ | ||
| "matrix": [1, 0, 0, 0, 0, 0, -1, 0, 0, 1, 0, 0, 0, 0, 0, 1], | ||
| "children": [], | ||
| "name": cm.j.get("metadata", "citymodel").get("identifier", "citymodel") |
There was a problem hiding this comment.
this was failing if there were no 'metadata' so I changed it. @hugoledoux can you verify that it is ok?
| print(i, v) | ||
| vtx_idx_np[i] = i | ||
| bin_vtx = vtx_np.astype(np.float32).tostring() |
| @@ -11,7 +11,7 @@ license_file = LICENSE | |||
|
|
|||
| [tool:pytest] | |||
| log_cli = true | |||
| collect_ignore = ['setup.py'] | |||
balazsdukai
approved these changes
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
TESTS:
IMPORTS:
RUFF CHECKS & FORMAT:
I will leave some extra comments below in some things that need attention